search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

update blueprint to handle newer test-helper.js #263

Closed bgentry closed 6 years ago

bgentry commented 6 years ago

On newer Ember versions, test-helper.js does not include an import { resolver } line anymore. Instead, we insert after the last line in the default test-helper.js, the qunit import.

This should support any version >= 2.17, which hopefully is good enough.

Fixes #262.

bgentry commented 6 years ago

Is there a good way to check the version here? Couldn’t find any blueprints that did that.

bgentry commented 6 years ago

I updated this using ember-cli-version-checker to support versions either before v2.17 or after.

sbatson5 commented 6 years ago

Thanks for the update @bgentry. Would you mind using yarn and not committing the package-lock file? I personally have no preference, but the repo was switched to yarn in https://github.com/poteto/ember-cli-flash/pull/233

bgentry commented 6 years ago

@sbatson5 dammit I have no idea how I committed that, sorry 😞 fixed now