search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

Upgrade to ember 3.0 #266

Closed jmar910 closed 6 years ago

jmar910 commented 6 years ago

Update dependencies and convert acceptance test to new unified testing goodness

sbatson5 commented 6 years ago

Thanks @jmar910. Did a quick glance and it looks good. I'll have some time tomorrow to look at why that one test is failing on ember-canary.

Dhaulagiri commented 6 years ago

@sbatson5 I'm inclined to stop running tests against canary, what do you think? The default travis setup ignores canary failures and I can't say I ever look at them for any addons, but I'm not sure how to do the same with circle without jumping through more hoops than seems worth it given that circle 1.0 is deprecated (i think).

sbatson5 commented 6 years ago

@Dhaulagiri I believe ember-canary is added to the default for ember-try but I believe it usually has an allowedToFail true. I'm fine updating that, so we can see the upstream failure but not block the PRs

Dhaulagiri commented 6 years ago

Oh nice, I never realized you could do it right in ember-try itself 💯

@jmar910 check out this config which shows how we can add a allowedToFail property in the ember try config and move this along

jmar910 commented 6 years ago

Awesome! on it

Dhaulagiri commented 6 years ago

turns out allowedToFail was already set for beta and canary @jmar910 but we removed it as we paired on this 🌵

jmar910 commented 6 years ago

lol yeah i noticed that whoops 😄