adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

remove deprecated usage of Ember.copy #274

Closed bgentry closed 6 years ago

bgentry commented 6 years ago

Fixes #173. Fixes deprecations in Ember v3.3.

izelnakri commented 6 years ago

@bgentry CI is failing somehow

bgentry commented 6 years ago

This is a bit annoying to reproduce since CircleCI has been down all day. Running yarn test locally, I am able to reproduce the failures. However, these exact same failures also occur on master:

not ok 35 Chrome 67.0 - FlashMessageComponent: it renders with the right props
    ---
        actual: >
            false
        expected: >
            true
        stack: >
                at Ember.run.next (http://localhost:7357/assets/tests.js:318:14)
                at invoke (http://localhost:7357/assets/vendor.js:27485:24)
                at Queue.flush (http://localhost:7357/assets/vendor.js:27403:25)
                at DeferredActionQueues.flush (http://localhost:7357/assets/vendor.js:27562:31)
                at Backburner._end (http://localhost:7357/assets/vendor.js:28008:42)
                at Backburner.end (http://localhost:7357/assets/vendor.js:27750:18)
        message: >
            it sets `active` to true after rendering
        negative: >
            false
        Log: |
    ...

So I believe this is an issue that needs to be fixed separately.

izelnakri commented 6 years ago

@poteto can we update this package?

bgentry commented 6 years ago

Just to restate: the test failures here also occur on master. Might want to open a separate issue about that but it shouldn’t necessarily block this PR (as long as you can verify the failures are the same, as I did).

Dhaulagiri commented 6 years ago

released in 1.6.5