Closed bgentry closed 6 years ago
@bgentry CI is failing somehow
This is a bit annoying to reproduce since CircleCI has been down all day. Running yarn test
locally, I am able to reproduce the failures. However, these exact same failures also occur on master
:
not ok 35 Chrome 67.0 - FlashMessageComponent: it renders with the right props
---
actual: >
false
expected: >
true
stack: >
at Ember.run.next (http://localhost:7357/assets/tests.js:318:14)
at invoke (http://localhost:7357/assets/vendor.js:27485:24)
at Queue.flush (http://localhost:7357/assets/vendor.js:27403:25)
at DeferredActionQueues.flush (http://localhost:7357/assets/vendor.js:27562:31)
at Backburner._end (http://localhost:7357/assets/vendor.js:28008:42)
at Backburner.end (http://localhost:7357/assets/vendor.js:27750:18)
message: >
it sets `active` to true after rendering
negative: >
false
Log: |
...
So I believe this is an issue that needs to be fixed separately.
@poteto can we update this package?
Just to restate: the test failures here also occur on master. Might want to open a separate issue about that but it shouldn’t necessarily block this PR (as long as you can verify the failures are the same, as I did).
released in 1.6.5
Fixes #173. Fixes deprecations in Ember v3.3.