feat(service): handle flash object preventDuplicates similar to global option

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli

https://www.npmjs.com/package/ember-cli-flash

MIT License

355 stars 113 forks source link

Closed makepanic closed 4 years ago

makepanic commented 6 years ago

fixes #281

Everything open for discussion :)

makepanic commented 6 years ago

I've made some changes so it'll always prefer the instance option over the global one. Also rebased onto latest master

makepanic commented 5 years ago

I've rebased this PR onto the current master

makepanic commented 4 years ago

@sbatson5 @abhilashlr do you think we could also merge/work on this PR?

We used it since 2018 in production and haven't seen any issues.

If so, I'll check if I can find anything to improve. Right now it's only rebased onto the current master.

abhilashlr commented 4 years ago

@sbatson5 Seems like the PR has test cases passing. If this is fine, I think we should merge it?

sarus commented 4 years ago

Would really love to see this capability.

alexdiliberto commented 4 years ago

Is there anything specific which is preventing this from being merged?

makepanic commented 4 years ago

Rebased it onto the current master