Migrate to circle 2.0 - Githubissues

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli

https://www.npmjs.com/package/ember-cli-flash

MIT License

355 stars 113 forks source link

Migrate to circle 2.0 #283

Closed Darshan-Chauhan closed 6 years ago

Darshan-Chauhan commented 6 years ago

This PR fixes #275

Please review it and let me know if any further changes are required. Thanks

Dhaulagiri commented 6 years ago

@Darshan-Chauhan thanks for tackling this! It looks like the test suite is having a problem installing packages or something? I'm not sure if it's related, but it doesn't look like circle is using yarn to install the deps when it was in the old circle config.

Darshan-Chauhan commented 6 years ago

@Dhaulagiri , hey sorry I din't get time in last couple of days. I'll take a look.

Darshan-Chauhan commented 6 years ago

@Dhaulagiri , I've fixed the build but however 1 test case is failing for

ember-release:- 3.3.1-release+8265f21b
ember-beta:- 3.5.0-beta.1.beta+878f274b
ember-canary:- 3.6.0-canary+77bb517e

Can you take a look?? Build link:- test_case_failure

Darshan-Chauhan commented 6 years ago

@Dhaulagiri , I saw that that particular test case is failing for all PR and for master also.

So I think except for test cases everything is working fine on CI version 2.0