search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

add qunit-dom and update component tests #286

Closed sbatson5 closed 5 years ago

sbatson5 commented 6 years ago

What's in this PR?

As discussed here: https://github.com/poteto/ember-cli-flash/pull/277#discussion_r206132419 We didn't want to add this dependency until it was actually used. This PR updates the tests to use qunit-dom when applicable. Also updates the modules for testing the component (integration and unit).

Dhaulagiri commented 6 years ago

Looks like the tests are unhappy

sbatson5 commented 6 years ago

Yeah, seems to only be failing on certain ember version. I can investigate this weekend

Dhaulagiri commented 5 years ago

@sbatson5 is this something you think you'll try to land at some point?

sbatson5 commented 5 years ago

@Dhaulagiri I've been meaning to come back to this, but work has been eating up too much time. I have to figure out why this fails in one particular instance.

I can close for now to reduce repo noise