search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

Upgrade to 1.7.0: Config undefined results in error #289

Closed mtgraham closed 5 years ago

mtgraham commented 5 years ago

https://github.com/poteto/ember-cli-flash/blob/e86f47dc963c5711d590a4ba12ca4d7a284fde4a/addon/services/flash-messages.js#L119

This property throws an error in my app's tests Error: Assertion Failed: Cannot call get with 'flashMessageDefaults' on an undefined object.

It seems that resolving the config from the registry returns undefined in this version.

cythrawll commented 5 years ago

Seems to be a problem in unit tests only. But we need to add a needs for 'config:environment' seems to fix the issue. Opened PR #290

olleolleolle commented 5 years ago

290 has been merged, does that help with this issue? Can this be closed, @mattgraham1995?

mtgraham commented 5 years ago

Yes that works.