adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

Fix guidFor import #299

Closed villander closed 5 years ago

villander commented 5 years ago

its fixes #298

// this works
import { guidFor } from '../utils/computed';
guidFor(whatever);

// and this works
import * as customComputed from '../utils/computed';
customComputed.guidFor(whatever);

// but this does not work.
import customComputed from '../utils/computed';
customComputed.guidFor(whatever);

This is a case where ember-cli historically allows a non-spec-compliant behavior.

cc: @Dhaulagiri

Dhaulagiri commented 5 years ago

Thanks! Will release soon-ish.

villander commented 5 years ago

thanks @Dhaulagiri

Dhaulagiri commented 5 years ago

Released in 1.7.2

villander commented 5 years ago

@Dhaulagiri you forget of publish this on npm

Dhaulagiri commented 5 years ago

@villander sorry about that, it should be actually published now 😸