adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

fix: ensure timers are cleaned up on service destroy #303

Closed makepanic closed 4 years ago

makepanic commented 5 years ago

I've noticed this because many of our acceptance tests lead into a flash appearing in the end (e.g. error flash or confirmation flash).

When investigating, there was always a dangling timer that slowed the test down:

20190927-100904

With this PR:

20190927-100958

sbatson5 commented 5 years ago

Awesome catch 👍

I need to investigate the Circle failure -- it's unrelated to your change

abhilashlr commented 4 years ago

@makepanic If you rebase with current master I believe it should pass this PR.

makepanic commented 4 years ago

rebased it onto the current master