Closed makepanic closed 4 years ago
I've noticed this because many of our acceptance tests lead into a flash appearing in the end (e.g. error flash or confirmation flash).
When investigating, there was always a dangling timer that slowed the test down:
With this PR:
Awesome catch 👍
I need to investigate the Circle failure -- it's unrelated to your change
@makepanic If you rebase with current master I believe it should pass this PR.
rebased it onto the current master
I've noticed this because many of our acceptance tests lead into a flash appearing in the end (e.g. error flash or confirmation flash).
When investigating, there was always a dangling timer that slowed the test down:
With this PR: