Closed sbatson5 closed 4 years ago
@sbatson5 I can help here ✋
Thanks! Let me know if you have questions. Like I said, I gave it a stab but hit a road block when it came to testing the timing logic. i.e.
I think the issue is around await render
versus the old this.render
-- I think await
is causing all the lifecycle hooks to finish before the assertions run but I haven't had the time to investigate
@sbatson5 @esbanarango I've clubbed #306 and #305 into a single PR - #308
That's great @abhilashlr 🙏. I'll check if there is any remaining work to-do during weekend.
Except for ember-release, and ember-canary the builds seem to pass. It is failing in CircleCI due to node version being 6. #309 attempts to address that.
Awesome! I should be able to take a look during some free time later today
The integration test currently on
master
is using the oldmoduleForComponent
format. I started working on updating it but ran into an issue with the timers. We'll want to update the test to this format: