search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

CHORE: Update node version on CircleCI to 8 #309

Closed abhilashlr closed 4 years ago

abhilashlr commented 4 years ago

This PR addresses #310

Turbo87 commented 4 years ago

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

abhilashlr commented 4 years ago

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

I will have this updated in package.json @Turbo87

abhilashlr commented 4 years ago

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

Also, this upgrade was done since Travis had been failing for sometime with PRs on this repo. Should we still support Node < 8?

Turbo87 commented 4 years ago

Should we still support Node < 8?

No, dropping support for these outdated Node versions is fine, but it should be done in a major version release because it should be considered a breaking change.

abhilashlr commented 4 years ago

Should we still support Node < 8?

No, dropping support for these outdated Node versions is fine, but it should be done in a major version release because it should be considered a breaking change.

Agree.