2.0 Roadmap - Githubissues

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli

https://www.npmjs.com/package/ember-cli-flash

MIT License

355 stars 113 forks source link

Closed abhilashlr closed 2 years ago

abhilashlr commented 4 years ago

Upgrade ember-cli-flash to 2.0 with the following items:

[ ] Remove initializer that injects flashMessages service. This will be a breaking change for apps since the apps would require to write their own initializer that will inject the service or follow dependency injection by doing:
```
flashMessages: inject.service()
```
[ ] Should 2.x support Ember 1.x and 2.x versions also?
[ ] Drop jQuery
[ ] Porting to typescript

Feel free to add more to this list of items.

makepanic commented 4 years ago

Porting the addon to typescript (via ember-cli-typescript) or adding type definitions would also be awesome.

With many options for adding flash messages, it's really helpful to get correct types for each field.

HerveSeger commented 4 years ago

I just upgraded my application to ember v3.14.2 and I can see the following deprecation:

So it should probably be added to the list.

st-h commented 4 years ago

@HerveSeger This should already be fixed in 1.8.0: https://github.com/poteto/ember-cli-flash/pull/304 However it seems that it hasn't been released yet.

stukalin commented 2 years ago

@abhilashlr close this perhaps? This addon is on 2.1.2 already with some of your suggestions in place.