search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

fix missing bind on mouse events listener #315

Closed st-h closed 4 years ago

st-h commented 4 years ago

This fixes missing binds for mouse event listeners as noticed in #304 . Tried to use the action helper, but this seems to only be available in recent ember versions, therefore using bind() to address this

Turbo87 commented 4 years ago

@sbatson5 @st-h is there anything we can do to move this forward?

st-h commented 4 years ago

@Turbo87 I am good with either approach, so I guess it's up to the maintainers do decide which to use