search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

Cannot Use Selectors on Flash Message #332

Closed jherdman closed 3 years ago

jherdman commented 3 years ago

Per ember-test-selectors:

Screen Shot 2020-10-21 at 2 17 15 PM

Seems like the Flash Message component ought to either revert the @tagName('') change, or port to Glimmer.

Techn1x commented 3 years ago

The component contains ...attributes so it should be fine for data test selectors. https://github.com/poteto/ember-cli-flash/blob/49aec796a5123481f9b546cd53409455f38c0c41/addon/templates/components/flash-message.hbs#L1-L3

How are you applying the selectors to the component? Also, does this help? https://github.com/simplabs/ember-test-selectors/issues/571

jherdman commented 3 years ago

I'm going to close this. It turns out we had a class and template override. Yay...