search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
355 stars 113 forks source link

feat: improved a11y for flash message component by default #336

Closed Techn1x closed 3 years ago

Techn1x commented 3 years ago

Just noticed this while working on https://github.com/poteto/ember-cli-flash/pull/335

I think role="alert" is what we want. There's also role="alertdialog" but I think that's more for when there is a decision to be made in a dialog context (eg yes/no/cancel)