search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
354 stars 113 forks source link

Upgrade ember cli #365

Closed stukalin closed 2 years ago

stukalin commented 3 years ago

Fix #361

stukalin commented 3 years ago

Note that's the canary build which causes the tests failure. In theory we can temporarily disable it. What do you think?

stukalin commented 3 years ago

@poteto may I ping you on this?

ndekeister-us commented 3 years ago

@stukalin issue on canary is fixed (see https://github.com/emberjs/ember-test-helpers/pull/1066), you could update @ember/test-helpers to 2.2.9+

But this scenario will probably still fails (see https://github.com/poteto/ember-cli-flash/pull/367, same import issue in this repo), maybe it is better to do the change on your PR so that we ensure ember-canary scenario will be ok?

stukalin commented 3 years ago

@ndekeister-us thanks for the comment! I'll try this one out

stukalin commented 3 years ago

@ndekeister-us fixed your comment. Would anyone else want to review/merge ther PR? @poteto ?

poteto commented 3 years ago

I don't work with Ember anymore so I don't think I can review this. Paging @sbatson5, @kategengler

sbatson5 commented 3 years ago

I don't work with Ember anymore so I don't think I can review this. Paging @sbatson5, @kategengler

I haven't worked in Ember for a couple years now, unfortunately.

stukalin commented 3 years ago

@kategengler may I ping you on this one then?

Turbo87 commented 2 years ago

@poteto @sbatson5 if you both don't work with Ember anymore, would you be open to transfering the repo to https://github.com/adopted-ember-addons/ ?

instructions for that are available in https://github.com/adopted-ember-addons/program-guidelines#getting-your-addon-adopted

sbatson5 commented 2 years ago

@poteto @sbatson5 if you both don't work with Ember anymore, would you be open to transfering the repo to https://github.com/adopted-ember-addons/ ?

instructions for that are available in https://github.com/adopted-ember-addons/program-guidelines#getting-your-addon-adopted

I'm just a maintainer and don't have the rights to transfer this repo. I support the decision, however!

poteto commented 2 years ago

@Turbo87 Yeah I think that's the best option. I'll reach out to get this transferred.

stukalin commented 2 years ago

@rahulk94 thanks a lot! Anyone with the "i am able to press the merge button" permission? @sbatson5 @poteto would you mind? (Sorry for bothering you each time guys)

stukalin commented 2 years ago

@poteto @Turbo87 any news on transferring the repo ?

GreatWizard commented 2 years ago

Thanks for your works here. The changes look good to me too :) This update is needed if we want to use ember v4... do you think you can merge and release it?

And see in a second time the transfer onto adopted addon?

stukalin commented 2 years ago

@GreatWizard i don't have enough permissions unfortunately

sbatson5 commented 2 years ago

👋 Sorry, for missing these pings. I can cut a release if y'all are confident as we wait for the transfer to "adopted-ember-addons"

RobbieTheWagner commented 2 years ago

@poteto @sbatson5 if you can transfer this repo to me, I am an owner on adopted-ember-addons and I can get this transferred there. I will also need you to please make me an owner on npm, I am rwwagner90 there as well.