search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
356 stars 113 forks source link

Cut a major 3.0 release #375

Closed bartocc closed 1 year ago

bartocc commented 2 years ago

ember-cli-flash@2.2.0 includes PR #373, which includes a dep on ember-cli-flash >= 2. Upgrading from ember-cli-flash@2.1.0 to ember-cli-flash@2.2.0 does not work on apps that depend on ember-auto-import@1.x

See my comment here https://github.com/poteto/ember-cli-flash/pull/373#issuecomment-1004860518

Techn1x commented 2 years ago

@sbatson5 might also want to cut a patch version for 2.2.x that reverts the breaking changes as well.

sbatson5 commented 2 years ago

Sorry for the mistake. Version 2.2.2 was pushed with the reverted changes.

Version 3.0.0 was released

RobbieTheWagner commented 2 years ago

Should there be a changelog entry for 3.0.0? I'm having trouble finding what the changes were.

sbatson5 commented 2 years ago

I would ping @stukalin for that contribution. I am really just keeping the lights on as I have admin access until the repo gets transferred. Would greatly appreciate a PR with those updates!

RobbieTheWagner commented 2 years ago

@sbatson5 @stukalin we should setup release-it with automatic changelog and release generation. We should also get this repo transferred to adopted-ember-addons perhaps.

rahulk94 commented 2 years ago

Transferring to the adopted-ember-addons org is the right thing here.

I believe @poteto reached out about doing that per https://github.com/poteto/ember-cli-flash/pull/365#issuecomment-963116400. Any updates on this?

RobbieTheWagner commented 2 years ago

@sbatson5 if you have admin access, could you transfer the repo to me? I can then transfer it to adopted-ember-addons

sbatson5 commented 2 years ago

@sbatson5 if you have admin access, could you transfer the repo to me? I can then transfer it to adopted-ember-addons

I do not have admin access. Just contributor

RobbieTheWagner commented 2 years ago

@poteto Could you please transfer the repo to me, so I could transfer to adopted-ember-addons?

poteto commented 2 years ago

@rwwagner90 Sorry about the delay! You'll need to delete your fork first, otherwise I can't transfer.

RobbieTheWagner commented 2 years ago

@poteto done, thanks for responding and thank you for agreeing to transfer! Also, I'm not sure the best way to get in touch with you these days, but we would love to have you on our podcast! If you might be interested, please email me at robbie@shipshape.io

RobbieTheWagner commented 1 year ago

We released 4.0.0, so this can be closed.