search

adopted-ember-addons / ember-cli-flash

Simple, highly configurable flash messages for ember-cli
https://www.npmjs.com/package/ember-cli-flash
MIT License
354 stars 113 forks source link

Modernise `FlashMessagesService` #409

Closed gilest closed 6 months ago

gilest commented 6 months ago

Replaces computeds, EmberArray, set/get, prototype extensions with native JS features.

Should make the conversion to TypeScript much easier.

Breaking since the types of these properties will be changing. Targeting 6.0.0 with all of the other breaking modernisation changes. Hopefully we can ship new types in the same release.

gilest commented 6 months ago

@NullVoxPopuli I have pushed the upstream branch but GitHub hasn't updated the PR page for some reason. I'll circle back in a while and re-stage if it doesn't update

Edit: it caught up