search

adopted-ember-addons / ember-cli-hot-loader

An early look at what hot reloading might be like in the ember ecosystem
MIT License
99 stars 13 forks source link

Components not wrapped in HMR container #104

Open joshkadis opened 5 years ago

joshkadis commented 5 years ago

Howdy, thanks @toranb and crew for your work on this! I'm finding that my components are not being wrapped in the HMR containing element. Any thoughts on why this would be the case?

I imagine you'd need some additional info in order to answer that; I'm new to Ember so let me know what details I can provide. Thanks 🙌

toranb commented 5 years ago

@joshkadis hey thanks for writing! This addon only works with ember-cli < 3.4 :) so assuming you are between ember 2.12-3.3 .... did you run the ember install command? As part of that execution did you say "yes" or "no" to the question about updating your resolver?

joshkadis commented 5 years ago

Using ember-cli: 3.1.3, installed with ember install, resolver.js looks like the example you provided. It looks like this shouldn't matter any longer, but my environment is called local instead of development

lifeart commented 5 years ago

@joshkadis you can try ember-ast-hot-load addon

toranb commented 5 years ago

@joshkadis could you reproduce the issue in a tiny ember app? I'd be happy to look it over at some point but without a broken ember-cli baseline it might be tough to diagnose the issue.

Also, the work @lifeart is doing might be of interest. He is a more active maintainer and his project works with ember-cli 3.4+