search

adopted-ember-addons / ember-cli-hot-loader

An early look at what hot reloading might be like in the ember ecosystem
MIT License
99 stars 13 forks source link

Consider deprecation or merging with ember-ast-hot-load? #105

Open rwjblue opened 5 years ago

rwjblue commented 5 years ago

For those that are unaware, @chancancode and I wrote this test to ensure that it was possible to hot reload templates in Ember and that we don't accidentally break the fundamental ability for this to work in future Ember versions.

Sometime after that @lifeart used the concepts in that test (along with many of the ideas from this addon) to implement https://github.com/lifeart/ember-ast-hot-load.

I'd like to discuss either deprecating this or merging that addon into this one. Thoughts?

lifeart commented 5 years ago

There is some questions with possible weak points for ast-hot-load implementation.

1.) Is any stable (public) way to forget components/templates? 2.) Regarding AST transform with MU naming convention it's pretty hard to extract component from templates (it may be local or external property, helper, component, string) (before: foo-bar, after: this.foo, @foo, Boo, FooBar etc). // update - looks like it's fixed 3.) Also, can't figure out how we can deal with nested components matching (currently all components with containing same name part was reloaded). // update - looks like it's fixed 4.) Is it possible to implement "selective" rebuild with new build pipilene? (current implementation waiting for new {appName}.js generate new file with only needed defines. I think we can significantly increase rebuild speed with kinda api to prevent default build behavour and send something like "builThisFile with/without deps" for me. 5.) Personally I think we need to provide glimmer.js support (any pointers to dig?)

I'm pretty sure we can provide kinda ember-cli-hot-loader fallback (if needed) in ast-hot-load version or bump major version ember-cli-hot-loader and backport ast-hot-load findings.

toranb commented 5 years ago

@rwjblue I'm happy to deprecate this officially. Part of me moving it to this organization was to help sunset it after I got wind @lifeart was rockin' a new addon without all the limitations I ran into building this original prototype.

What is the recommend "process" or documentation to clearly communicate "yup, this is no longer maintained" ?