Once merged this PR will mark the v1.0 of this prototype hot reloader. The breaking change included here is that instead of tagName: "" for the wrapper component as we did pre 1.0 ... this will have a default div. This solves #68 and shouldn't harm anything related to hot reloading specifically. It could alter the way an application looks visually so that's the reason we are doing a major bump :)
To remove the targetObject deprecation warning I've also dropped this in favor of target instead. This could mean that much older versions of ember are no longer supported and if so the pre 1.0 version of this could live on for anyone who needs it. At some point I needed to make a clean break from the older targetObject else it would break for ember apps in the future :(
And finally, I've included a simplification/ reordering of the container cache break. I've tested this w/ ember 2.18LTS, 3.0, 3.1.3, 3.2.2 and the latest 3.3 beta so I'm feeling good about the move. If anyone finds a problem with ember versions below 2.18LTS please let me know.
Once merged this PR will mark the v1.0 of this prototype hot reloader. The breaking change included here is that instead of
tagName: ""for the wrapper component as we did pre 1.0 ... this will have a default div. This solves #68 and shouldn't harm anything related to hot reloading specifically. It could alter the way an application looks visually so that's the reason we are doing a major bump :)To remove the
targetObjectdeprecation warning I've also dropped this in favor oftargetinstead. This could mean that much older versions of ember are no longer supported and if so the pre 1.0 version of this could live on for anyone who needs it. At some point I needed to make a clean break from the oldertargetObjectelse it would break for ember apps in the future :(And finally, I've included a simplification/ reordering of the container cache break. I've tested this w/ ember 2.18LTS, 3.0, 3.1.3, 3.2.2 and the latest 3.3 beta so I'm feeling good about the move. If anyone finds a problem with ember versions below 2.18LTS please let me know.