search

adopted-ember-addons / ember-cli-hot-loader

An early look at what hot reloading might be like in the ember ecosystem
MIT License
99 stars 13 forks source link

Attempt to fix #97 #98

Closed lifeart closed 6 years ago

toranb commented 6 years ago

@lifeart not ignoring you on purpose ;) btw. I spoke w/ some of the core team at EmberCamp last week and it's possible the wrapper component + resolver mixin might be implementation details we can remove w/ some new information and help (more to come in the weeks ahead).

While we wait to see what comes of all that^ I'm curious in this PR how we might know the ordering of these function invocations is important. We don't have many tests yet around how the custom resolver functionality works but I'm curious if it would be possible to better document it with some type of test (that proves this is needed/ required to solve the issue you found)

lifeart commented 6 years ago

@toranb agreed, I'm interesting, why we return undefined in original logic? I think this fix can be more relevant - we can check template name for ignoring and return resolved value only for ignored templates.

toranb commented 6 years ago

@lifeart I want to say that returning undefined like we had it was something I found in the ember resolver itself (for resolveOther) as a way to signal that we bailed out early/ with nothing to show for it.