search

adopted-ember-addons / ember-cli-hot-loader

An early look at what hot reloading might be like in the ember ecosystem
MIT License
99 stars 13 forks source link

Slashed components rendering and ignore issue fix #99

Closed lifeart closed 6 years ago

lifeart commented 6 years ago

instead of https://github.com/toranb/ember-cli-hot-loader/pull/98 fix for https://github.com/toranb/ember-cli-hot-loader/issues/97 including test components

toranb commented 6 years ago

@lifeart wow this looks like a TON of work! Thank you for pouring all the time into this from a test point of view!

toranb commented 6 years ago

@lifeart bummer - this had a regression (published version v1.4.1) so I had to revert and publish v1.4.2

If you have time this week could you triage what broke w/ your changes here? I think this PR offers something of value but I didn't want to break the addon for users who are having good luck w/ v1.4

You can use this demo app to triage further (error was action related)

https://github.com/toranb/ember-hot-reload-demo

lifeart commented 6 years ago

@toranb sorry for regression, going to check what's going on