search

adopted-ember-addons / ember-cli-sass

Use node-sass to preprocess your ember-cli app's files, with support for sourceMaps and include paths
MIT License
274 stars 91 forks source link

Use *either* addon or app options, never both. #205

Closed chriskrycho closed 5 years ago

chriskrycho commented 5 years ago

Fixes #204.

chriskrycho commented 5 years ago

Would love eyes here from someone like @stefanpenner, @rwjblue, @dfreeman, etc.

chriskrycho commented 5 years ago

Updated with the suggested changes, but I need to whip up a small demo app to confirm that this does what I expect it too.

chriskrycho commented 5 years ago

Confirmed via this example code that the updated version still resolves this. Good for merge.

chriskrycho commented 5 years ago

@aexmachina if you wouldn't mind giving this the old merge and/or finishing out the transfer as suggested in #203 so someone else can, that'd be fantastic. I know there's at least one team blocked on this, and likely a bunch of others.

Note to whoever does end up merging this: it should probably be a new major, as this could break users. In terms of the explicit contract, this would be a bugfix as nothing has changed, but the implementation for looking up options is sufficiently different that users who were implicitly depending on the previous behavior may experience breakage.

simonexmachina commented 5 years ago

Thanks! Pushed v10.

I do intend to transfer ownership, but don't have bandwidth right now.

chriskrycho commented 5 years ago

Thanks for getting this merged and published, @aexmachina!