adopted-ember-addons / ember-collection

An efficient incremental rendering component for Ember.js with support for custom layouts and large lists
https://ember-collection.netlify.app/
MIT License
236 stars 84 forks source link

Inline style on cell violates csp #121

Open BryanCrotaz opened 8 years ago

BryanCrotaz commented 8 years ago
// addon/components/ember-collection/template.hbs
...
{{~#each _cells as |cell|~}}
    <div style={{{cell.style}}}>{{yield cell.item cell.index }}</div>
{{~/each~}}
...

What's a good way to apply the style using js? I've done this successfully in ember-cli-csp-style but that only works on the root element. Can't use a helper as it doesn't know its target context.

Happy to write a PR for this if someone more familiar with Glimmer can hint at a good way to solve.

krisselden commented 8 years ago

It's because it is using a path that goes through setAttribute which then uses the CSS parser, if it did style prop of the element that would work. This though would need to expose the current element modifier API which isn't public or become a component.

BryanCrotaz commented 8 years ago

I've refactored as a component - getting it working in a fork then submitting a PR