search

adopted-ember-addons / ember-collection

An efficient incremental rendering component for Ember.js with support for custom layouts and large lists
https://ember-collection.netlify.app/
MIT License
236 stars 84 forks source link

Ember global deprecation violation, transitive dependency on ember-cli-babel@6 #221

Closed 22a closed 10 months ago

22a commented 1 year ago

This addon has a transitive dependency on a version of ember-cli-babel below 7.26.6 via the layout-bin-packer addon:

https://github.com/adopted-ember-addons/ember-collection/blob/279a75527c06997e2dcff8803da76290b9df6b9a/package.json#L28

https://github.com/adopted-ember-addons/ember-collection/blob/279a75527c06997e2dcff8803da76290b9df6b9a/yarn.lock#L9004-L9009 This causes the ember global deprecation warning to throw.

I've opened a PR to upgrade layout-bin-packer's ember-cli-babel version but I'm not yet certain this is the correct approach nor how this package can be released / who has access. I'll reach out in discord.

In the meantime, I'm opening THIS issue to track the progress towards getting that resolved and upsteamed here.

Details of the not-recommended, temporary workaround I'm using to unblock us for now

I've forked the repo to my employer's corporate GitHub account and [tagged a commit](https://github.com/intercom/layout-bin-packer/releases/tag/v2.0.0-ember.cli.babel.7.fork) that removed the `dist` dir from the packages `.gitignore` so the above PR can be used ``` "resolutions": { "layout-bin-packer": "intercom/layout-bin-packer#v2.0.0-ember.cli.babel.7.fork" }, ```

hexadecy commented 10 months ago

Fixed in ember-collection 3.0.0 it use:

layout-bin-packer "^2.0.0"