adopted-ember-addons / ember-cp-validations

Ember computed property based validations
https://adopted-ember-addons.github.io/ember-cp-validations/
BSD 3-Clause "New" or "Revised" License
442 stars 174 forks source link

Update ember-cli to v4.4 and drop support for node v12 #731

Closed fsmanuel closed 1 year ago

fsmanuel commented 1 year ago

There will be a follow up PR with the update to ember-cli v4.8 as that is more involved and needs changes for ember-data to work.

Release, Beta, and Canary are expected to fail. Current test coverage is 3.28 -> 4.4

https://github.com/adopted-ember-addons/ember-cp-validations/issues/716

knownasilya commented 1 year ago

Could you add ember 4.4 to ember-try/actions configs?

fsmanuel commented 1 year ago

@knownasilya We don't need to add 4.4 as it's the default (in package.json) and tested via the normal tests. It seems ember-cli-update takes good care of that and the next update to ember-cli v4.8 will add the ember-lts-4.4 scenario.

fsmanuel commented 1 year ago

@knownasilya Thanks for the review!