Open fsmanuel opened 10 months ago
This topic got raise by @Pixelik in https://github.com/adopted-ember-addons/ember-cp-validations/issues/733. I did some digging but figured I don't have enough knowledge about embroider. So all help is appreciated!
In an efford to have all the findings in one place, here is what I found:
The genesis of addon/-private/ember-internals.js:
addon/-private/ember-internals.js
import __EMBER_METAL__ from '@ember/-internals/metal/index';
So I have two assumptions:
Now my question is, how do we get the import embroider safe or even better remove it altogether? I found:
We already borrowed a lot of the changes in the qonto fork so if this solution is still recommended by the embroider team I would say we use require and refactor the internals like I proposed here: https://github.com/adopted-ember-addons/ember-cp-validations/pull/735#issuecomment-1779742888 (maybe we don't even need the fix from @Pixelik)
require
The same goes for import { meta } from '@ember/-internals/meta';
import { meta } from '@ember/-internals/meta';
//cc @ef4 @gilest
This topic got raise by @Pixelik in https://github.com/adopted-ember-addons/ember-cp-validations/issues/733. I did some digging but figured I don't have enough knowledge about embroider. So all help is appreciated!
In an efford to have all the findings in one place, here is what I found:
The genesis of
addon/-private/ember-internals.js
:import __EMBER_METAL__ from '@ember/-internals/metal/index';
So I have two assumptions:
Now my question is, how do we get the import embroider safe or even better remove it altogether? I found:
We already borrowed a lot of the changes in the qonto fork so if this solution is still recommended by the embroider team I would say we use
require
and refactor the internals like I proposed here: https://github.com/adopted-ember-addons/ember-cp-validations/pull/735#issuecomment-1779742888 (maybe we don't even need the fix from @Pixelik)The same goes for
import { meta } from '@ember/-internals/meta';
//cc @ef4 @gilest