Replace require with @embroider/macros fixing embroider support

adopted-ember-addons / ember-cp-validations

Ember computed property based validations

BSD 3-Clause "New" or "Revised" License

442 stars 174 forks source link

Closed achambers closed 1 year ago

achambers commented 1 year ago

In order to place nicely with Embroider, we need to remove require. Instead we can use dependencySatisfies and importSync.

Resolves #740

Changes proposed:

Remove require and replace with dependencySatisfies and importSync. (docs)

Tasks:

N/A

fsmanuel commented 1 year ago

@achambers Awesome!

fsmanuel commented 1 year ago

@achambers is this also possible for import __EMBER_METAL__ from '@ember/-internals/metal/index'; https://github.com/adopted-ember-addons/ember-cp-validations/issues/739?