search

adopted-ember-addons / ember-data-factory-guy

Factories and helper functions for (unit, integration, acceptance) testing + development scenarios with Ember Data
MIT License
301 stars 136 forks source link

Change import of deprecate from @ember/application/deprecations to @ember/debug #458

Closed colinfkennedy closed 2 years ago

colinfkennedy commented 2 years ago

The existing import is preventing apps upgrading to Ember 4 due to a missing module error.

Screenshot 2022-02-13 at 11 26 51 a m

The module @ember/application/deprecations no longer exists in Ember 4.

As the deprecate function is available in @ember/debug in Emberv3.28 (Current Ember version for ember-data-factory-guy) and Ember v4.0.0 this should be safe to change.

I have tested this locally with my own Ember 4 app.

patocallaghan commented 2 years ago

Thanks @colinfkennedy 🙇‍♂️ Have some failing tests but they're unrelated to your changes. Will merge your fixes anyway.