search

adopted-ember-addons / ember-data-factory-guy

Factories and helper functions for (unit, integration, acceptance) testing + development scenarios with Ember Data
MIT License
301 stars 136 forks source link

Fix ember-assign deprecation #480

Closed drouhard closed 1 year ago

drouhard commented 1 year ago

Purpose

Address deprecation warnings. (See https://github.com/emberjs/rfcs/blob/master/text/0750-deprecate-ember-assign.md)

Fix https://github.com/adopted-ember-addons/ember-data-factory-guy/issues/479

Summary

Follow the suggestion in the deprecation RFC and use a backwards-compatible helper for assign that pulls in @ember-polyfill/assign only when the consumer doesn't have Object.assign. (That is, for IE11 users).

drouhard commented 1 year ago

@patocallaghan I think this should help with https://github.com/adopted-ember-addons/ember-data-factory-guy/issues/479. Are you still the right person to review and get this merged?

patocallaghan commented 1 year ago

@drouhard I actually think we can just drop this outright and use Object.assign everywhere. How about we just do that instead? We're kind of gearing up for a major version bump and I think that will allow us to make this breaking change (drop IE11 support)

drouhard commented 1 year ago

Love it. Closing this PR in favor of taking your suggestion, here: https://github.com/adopted-ember-addons/ember-data-factory-guy/pull/481