search

adopted-ember-addons / ember-data-factory-guy

Factories and helper functions for (unit, integration, acceptance) testing + development scenarios with Ember Data
MIT License
301 stars 136 forks source link

[BREAKING] Replace polyfill assign with Object.assign #481

Closed drouhard closed 1 year ago

drouhard commented 1 year ago

Purpose

Address deprecation warnings. (See https://github.com/emberjs/rfcs/blob/master/text/0750-deprecate-ember-assign.md)

Fix https://github.com/adopted-ember-addons/ember-data-factory-guy/issues/479

Part of the quest towards a v4 release: https://github.com/adopted-ember-addons/ember-data-factory-guy/issues/444

Summary

Replaces assign from @ember/polyfills with javascript built-in Object.assign.

NOTE that Object.assign is not available in IE11, so this commit removes some IE11 support.

patocallaghan commented 1 year ago

@drouhard it looks like you have a bunch of conflicting files. Any chance you could resolve those please?

drouhard commented 1 year ago

@patocallaghan Oops, sorry about the hassle. My personal fork was quite a bit behind this repo. Good to go now 👍

patocallaghan commented 1 year ago

Thanks @drouhard. Appreciate the contribution 🙌

patocallaghan commented 1 year ago

FYI @drouhard I released an alpha release with this change in v4.0.0-alpha.1.

drouhard commented 1 year ago

Woo hoo! Thanks for the heads up @patocallaghan.