adopted-ember-addons / ember-data-factory-guy

Factories and helper functions for (unit, integration, acceptance) testing + development scenarios with Ember Data
MIT License
301 stars 136 forks source link

can we publish a release #483

Closed Techn1x closed 1 year ago

Techn1x commented 1 year ago

I hate to be that guy but any chance we could get a patch release published? (please :smile: )

Hoping to consume the object assign deprecation fix https://github.com/adopted-ember-addons/ember-data-factory-guy/pull/481

Otherwise it's a bit hard to see the forest from the trees in the dev console when booting up with a lot of models :) Screenshot from 2023-02-22 17-24-50 Screenshot from 2023-02-22 17-25-00

Techn1x commented 1 year ago

(I know I can filter the console, I just want my output clean :sparkles: )

RosarioAleCali commented 1 year ago

I agree with @Techn1x... it would be much appreciated!

Techn1x commented 1 year ago

@patocallaghan friendly ping

patocallaghan commented 1 year ago

@Techn1x sorry for the delay. After looking into it. Fixing this deprecation is actually a major breaking change (drops IE11 support) so will have to do an alpha release and there are other breaking changes we’d like to get in. The alternative for you is to use something like patch-package and cherry pick the fix

patocallaghan commented 1 year ago

I’ll cut an alpha later but it won’t be the full major release version

patocallaghan commented 1 year ago

@Techn1x @RosarioAleCali I've released the change in v4.0.0-alpha.1. I've to update the release notes but FYI there are three breaking changes

Techn1x commented 1 year ago

Thanks Pat, that's a fair point and I think the alpha release is a good way to tackle it.

Given that this tool is for dev / testing, I do wonder if we need to care that much about dropping IE - but I understand the importance of semver :)

patocallaghan commented 1 year ago

@Techn1x Yeah you just don't know how folks are using this tool but at least following proper semver makes that versioning decision for us 👍