search

adopted-ember-addons / ember-data-model-fragments

Ember Data addon to support nested JSON documents
MIT License
369 stars 114 forks source link

Array attribute typing seems to be wrong #457

Open canrozanes opened 1 year ago

canrozanes commented 1 year ago

The following line suggest that array attribute takes in two arguments, type and options. https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/addon/attributes.js#L151

Whereas the existing type information defined in the line below suggest array attribute does not take any arguments: https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/attributes.d.ts#L33

knownasilya commented 1 year ago

Looks like the types need updating, since the options are used for { defaultValue }. https://github.com/adopted-ember-addons/ember-data-model-fragments/blame/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/addon/attributes.js#L129