search

adopted-ember-addons / ember-electron

:zap: Build, test, compile and package desktop apps with Ember and Electron
https://ember-electron.js.org/
Other
805 stars 109 forks source link

'requireNode' is not defined #164

Closed nahtnam closed 7 years ago

nahtnam commented 7 years ago

After creating a new app, if you try to import a node library, you get the following error: 'requireNode' is not defined

The current workaround is to go to node_modules/ember-electron/lib/resources and edit both of the files and change (this) at the bottom to (window). While the workaround works, it will fail in CI's and other places where you cant easily modify the node_modules.

Thanks.

bendemboski commented 7 years ago

Fixed in 2.0 via https://github.com/felixrieseberg/ember-electron/commit/118a140963685dc42faf97b54f7279807522b702