Closed pichfl closed 7 years ago
@pichfl I like the idea of warning when ember-welcome-page is detected, at least for all the commands/-build
variants.
Can you take this on, or otherwise close this issue given the docs branch is merged?
Will take care of this once #188 lands.
Closed in favor of #203
Extracted from #173
Up to now I can report this:
welcome-page
and exports assets now. No more express middleware.ember electron
--env=production
, which is our default, this happens, because the addon is configured to bail if in production. See code here.--env=development
, it works as well.We should consider:
ember-welcome-page
is detectedember-electron-welcome
as suggested by @bendemboskiWhile I think 3) is quite interesting, I don't think it is that useful. While some people might start using our addon to create a brand new app, coming from the ember side with a working app in place is a equally likely scenario. I don't want to mess too much with other peoples apps, especially their templates. Therefore putting out a warning if we detect both the template tag and the addon (or just the addon) we should put out a big warning. If we detect both, we might be able to assume the user runs
ember-electron
from a brand new app and replace the addon with our own page, but that seems like a lot of work right now. Showing a link to a possible "Getting Started with ember-electron" next to the warning in the console should be sufficient.