search

adopted-ember-addons / ember-electron

:zap: Build, test, compile and package desktop apps with Ember and Electron
https://ember-electron.js.org/
Other
805 stars 109 forks source link

Beta: Output in /dist no longer lines up with default output #177

Closed pichfl closed 7 years ago

pichfl commented 7 years ago

In our latest iteration the output in /dist is now quite different for ember electron than it is for ember build, which might lead to some confusion, especially in projects that are not exclusively using with Electron.

This might be a non-issue, but I had to note this down somewhere.

jacobq commented 7 years ago

This was mentioned during the copy-files discussion, and I think it definitely deserves some explanation in the docs. Fortunately, a quick glance at the contents of dist reveals an ember folder which has the expected structure, so I don't think it's going to cause too much pain.

anulman commented 7 years ago

I agree this is an issue. My preference would be to build to a separate dir (e.g. ember, electron-dist) in the root dir, and clean up on completion of those commands.

bendemboski commented 7 years ago

We could just add electron-dist to .npmignore and change the default here if we think this is going to cause confusion, but I would expect anybody running an ember-electron app will know enough to not be surprised to find the electron app in dist instead of their ember app files.

anulman commented 7 years ago

My concern is not with "surprise to find it in their files" and instead with publishing scripts meant to push dist to remote hosts. I don't feel comfortable leaving these artifacts around (edit: in a path where users would reasonably expect something else + may have built tooling around that assumption).

bendemboski commented 7 years ago

Okay, as I said, the fix should be really easy.

pichfl commented 7 years ago

This is gone now that #188 is merged. Closing.