search

adopted-ember-addons / ember-electron

:zap: Build, test, compile and package desktop apps with Ember and Electron
https://ember-electron.js.org/
Other
805 stars 109 forks source link

Investigate: require shim no longer working in 2.x #241

Closed pichfl closed 6 years ago

pichfl commented 7 years ago

Seems there is some problem with the way we handle require. See https://github.com/felixrieseberg/ember-electron/issues/147#issuecomment-297407509

This used to work and as I refactored there, I might have made an error. Will investigate.

bendemboski commented 7 years ago

I don't think there's a bug -- the comment was updated to indicate that it was a require vs. requireNode problem.

At some point it might be worth looking to getting rid of that by using loader.js's noConflict functionality...