search

adopted-ember-addons / ember-electron

:zap: Build, test, compile and package desktop apps with Ember and Electron
https://ember-electron.js.org/
Other
805 stars 111 forks source link

Install Error - Failed to install modules #344

Closed ksolo closed 6 years ago

ksolo commented 6 years ago

OS: MacOSX 10.13.3 Ember CLI: 2.17.2 Node Version: 9.2.0

$ ember install ember-electron

Results:

Yarn: Installed ember-electron
installing ember-electron
  identical ember-electron/.compilerc
  identical ember-electron/main.js
  identical ember-electron/test-main.js
  identical testem-electron.js
Project needs forge config
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
bendemboski commented 6 years ago

@ksolo can you run

$ DEBUG=electron-forge:* ember install ember-electron

and post the output? Need more info...

ksolo commented 6 years ago

@bendemboski 

$ DEBUG=electron-forge:* ember install ember-electron
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
Yarn: Installed ember-electron
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
installing ember-electron
  identical ember-electron/.compilerc
  identical ember-electron/main.js
  identical ember-electron/test-main.js
  identical testem-electron.js
Project needs forge config
⠋ Installing electron build tools  electron-forge:import Attempting to import project in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:init:git .git directory already exists, skipping git initialization +0ms
  electron-forge:import reading current scripts object: { build: 'ember build',
  start: 'ember serve',
  test: 'ember test' } +5ms
  electron-forge:import forgified scripts object: { build: 'ember build',
  start: 'ember serve',
  test: 'ember test' } +1ms
  electron-forge:import deleting old dependencies forcefully +3ms
  electron-forge:import installing dependencies +0ms
  electron-forge:dependency-installer installing ["electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop dev=false,exact=false,withYarn=true +0ms
  electron-forge:dependency-installer executing ["add","electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:runtime-config fetching key verbose +0ms
⠦ Installing electron build tools  electron-forge:import installing devDependencies +7s
  electron-forge:dependency-installer installing ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop dev=true,exact=false,withYarn=true +7s
  electron-forge:dependency-installer executing ["add","babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge","--dev"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:runtime-config fetching key verbose +7s
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1

I'll try adding these dependencies via yarn directly to see if that gives us more.

ksolo commented 6 years ago

When I run:

$ DEBUG=electron-forge:* yarn add electron-forge --dev

I get this error:

error An unexpected error occurred: "/Users/ksolo/Projects/Chair-Flyers/cf-desktop/node_modules/ember-electron/node_modules/electron-forge: Command failed.
Exit code: 1
Command: sh
Arguments: -c node tabtab-install.js
Directory: /Users/ksolo/Projects/Chair-Flyers/cf-desktop/node_modules/ember-electron/node_modules/electron-forge
ksolo commented 6 years ago

Looks like I'm missing tabtab-install.js

bendemboski commented 6 years ago

Electron forge is getting installed correctly -- that's not the problem. It's failing when it tries to install some other dependencies into your project. Reset your project to a clean state (blow away node_modules and re-install), then ember install command. After it fails, run

$ yarn add babel-preset-env babel-preset-react babel-plugin-transform-async-to-generator electron-forge --dev
bendemboski commented 6 years ago

Oh, uh, hmm...maybe you were right, it looks like electron-forge is trying to (re-)install itself, I guess because it thinks it's installed globally. Anyway, run the above command and post the output.

ksolo commented 6 years ago 
$ember install ember-electron
Yarn: Installed ember-electron
installing ember-electron
  identical ember-electron/.compilerc
  identical ember-electron/main.js
  identical ember-electron/test-main.js
  identical testem-electron.js
Project needs forge config
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
$ yarn add babel-preset-env babel-preset-react babel-plugin-transform-async-to-generator electron-forge --dev
yarn add v1.5.1
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
warning Pattern ["babel-preset-env@^1.6.1"] is trying to unpack in the same destination "/Users/ksolo/Library/Caches/Yarn/v1/npm-babel-preset-env-1.6.1-a18b564cc9b9afdf4aae57ae3c1b0d99188e6f48" as pattern ["babel-preset-env@^1.5.1"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["babel-plugin-transform-async-to-generator@^6.24.1"] is trying to unpack in the same destination "/Users/ksolo/Library/Caches/Yarn/v1/npm-babel-plugin-transform-async-to-generator-6.24.1-6536e378aff6cb1d5517ac0e40eb3e9fc8d08761" as pattern ["babel-plugin-transform-async-to-generator@^6.22.0","babel-plugin-transform-async-to-generator@^6.22.0"]. This could result in non-deterministic behavior, skipping.
[4/5] 🔗  Linking dependencies...
[5/5] 📃  Building fresh packages...
[-/7] ⢀ waiting...
[-/7] ⢀ waiting...
[3/7] ⢀ node-sass: Downloading binary from https://github.com/sass/node-sass/releases/download/v4.7.2/darwin-x64-59_binding.node
[7/7] ⢀ electron-forge
error An unexpected error occurred: "/Users/ksolo/Projects/Chair-Flyers/cf-desktop/node_modules/ember-electron/node_modules/electron-forge: Command failed.
Exit code: 1
Command: sh
Arguments: -c node tabtab-install.js
Directory: /Users/ksolo/Projects/Chair-Flyers/cf-desktop/node_modules/ember-electron/node_modules/electron-forge
Output:
ksolo commented 6 years ago

I can add tabtab

$ yarn add tabtab --dev

Then 

$ node_modules/.bin/tabtab install

Which asks where to install a script (I selected stdout)

 tabtab:installer Zsh shell detected +0ms
? Where do you want to setup the completion script stdout
  tabtab:installer Installing completion script to stdout directory +25s

###-begin-ChairFlyers-completion-###
if type compdef &>/dev/null; then
  _ChairFlyers_completion () {
    local reply
    local si=$IFS

    IFS=$'\n' reply=($(COMP_CWORD="$((CURRENT-1))" COMP_LINE="$BUFFER" COMP_POINT="$CURSOR" ChairFlyers completion -- "${words[@]}"))
    IFS=$si

    _describe 'values' reply
  }
  compdef _ChairFlyers_completion ChairFlyers
fi
###-end-ChairFlyers-completion-###

This doesn't add a tabtab-install.js file in my project root, which when thesh -c "node tabtab-install.js" is executed it fails...

bendemboski commented 6 years ago

Hmm...there have been some fixes in electron-forge for issues related to tabtab, but we haven't released our ember-electron version with the latest electron-forge. Can you try

$ ember install ember-electron@https://github.com/felixrieseberg/ember-electron.git#378f70e980cddaa2a9280bf9609b94e8c85d73b3

to install the latest master of ember-electron that uses a newer electron-forge?

ksolo commented 6 years ago

This was the last output. I have to run, but will be back on tonight to keep trying.

$ ember g ember-electron
installing ember-electron
  identical .travis.yml
  identical ember-electron/.compilerc
  identical ember-electron/.eslintrc.js
  identical ember-electron/main.js
  identical ember-electron/test-main.js
  identical testem-electron.js
  identical tests/ember-electron/.eslintrc.js
Project needs forge config
⠹ Installing electron build toolsFailed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
bendemboski commented 6 years ago

Er, yeah, sorry, run

$ DEBUG=electron-forge:* ember install ember-electron@https://github.com/felixrieseberg/ember-electron.git#378f70e980cddaa2a9280bf9609b94e8c85d73b3

I suspect we'll get the same output as before, but let's double-check...

ksolo commented 6 years ago

You were right, getting the same output.

$ DEBUG=electron-forge:* ember install ember-electron@https://github.com/felixrieseberg/ember-electron.git#378f70e980cddaa2a9280bf9609b94e8c85d73b3
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
Yarn: Installed ember-electron@https://github.com/felixrieseberg/ember-electron.git#378f70e980cddaa2a9280bf9609b94e8c85d73b3
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
installing ember-electron
  identical .travis.yml
  identical ember-electron/.compilerc
  identical ember-electron/.eslintrc.js
  identical ember-electron/main.js
  identical ember-electron/test-main.js
  identical testem-electron.js
  identical tests/ember-electron/.eslintrc.js
Project needs forge config
⠋ Installing electron build tools  electron-forge:import Attempting to import project in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:init:git .git directory already exists, skipping git initialization +0ms
  electron-forge:import reading current scripts object: { build: 'ember build',
  start: 'ember serve',
  test: 'ember test' } +5ms
  electron-forge:import forgified scripts object: { build: 'ember build',
  start: 'ember serve',
  test: 'ember test' } +2ms
  electron-forge:import deleting old dependencies forcefully +2ms
  electron-forge:import installing dependencies +0ms
  electron-forge:dependency-installer installing ["electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop dev=false,exact=false,withYarn=true +0ms
  electron-forge:dependency-installer executing ["add","electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:runtime-config fetching key verbose +0ms
⠏ Installing electron build tools  electron-forge:import installing devDependencies +6s
  electron-forge:dependency-installer installing ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop dev=true,exact=false,withYarn=true +6s
  electron-forge:dependency-installer executing ["add","babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge","--dev"] in: /Users/ksolo/Projects/Chair-Flyers/cf-desktop +0ms
  electron-forge:runtime-config fetching key verbose +6s
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
ksolo commented 6 years ago

I created an empty app and did an install of electron-forge, which went ok by itself:

$ yarn add electron-forge --dev
yarn add v1.5.1
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning electron-forge > s3 > graceful-fs@3.0.11: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
warning electron-forge > zip-folder > archiver > glob > minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning electron-forge > electron-windows-store > flatten-packages > wrench@1.5.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
warning electron-forge > nugget > progress-stream > through2 > xtend > object-keys@0.4.0:
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 377 new dependencies.
info Direct dependencies
└─ electron-forge@5.1.1
info All dependencies
├─ @octokit/rest@14.0.9
├─ ajv@5.5.2
├─ ansi-escapes@3.0.0
├─ ansi-styles@3.2.1
├─ ansi@0.3.1
├─ appdmg@0.4.5
├─ aproba@1.2.0
├─ archiver@0.11.0
├─ argparse@1.0.10
├─ array-buffer-from-string@0.1.0
├─ array-find-index@1.0.2
├─ asn1@0.2.3
├─ asynckit@0.4.0
├─ attempt-x@1.1.3
├─ author-regex@1.0.0
├─ aws-sdk@2.205.0
├─ aws-sign2@0.7.0
├─ aws4@1.6.0
├─ babel-core@6.26.0
├─ babel-generator@6.26.1
├─ babel-helpers@6.24.1
├─ babel-register@6.26.0
├─ babel-template@6.26.0
├─ balanced-match@1.0.0
├─ base32-encode@0.1.1
├─ base64-js@1.2.0
├─ bcrypt-pbkdf@1.0.1
├─ before-after-hook@1.1.0
├─ binary@0.3.0
├─ bl@0.9.5
├─ block-stream@0.0.9
├─ bluebird@3.5.1
├─ boom@4.3.1
├─ bplist-creator@0.0.7
├─ brace-expansion@1.1.11
├─ buffer-from@0.1.1
├─ buffer@4.9.1
├─ buffers@0.1.1
├─ builtin-modules@1.1.1
├─ camelcase-keys@2.1.0
├─ caseless@0.12.0
├─ chainsaw@0.1.0
├─ chalk@2.3.2
├─ chardet@0.4.2
├─ cli-cursor@2.1.0
├─ cli-spinners@1.1.0
├─ cli-width@2.2.0
├─ co@4.6.0
├─ code-point-at@1.1.0
├─ color-convert@1.9.1
├─ color-name@1.1.3
├─ combined-stream@1.0.6
├─ commander@2.14.1
├─ compare-version@0.1.2
├─ compress-commons@0.1.6
├─ concat-map@0.0.1
├─ concat-stream@1.6.0
├─ console-control-strings@1.1.0
├─ convert-source-map@1.5.1
├─ core-js@2.5.3
├─ core-util-is@1.0.2
├─ cp-file@3.2.0
├─ crc32-stream@0.3.4
├─ cross-spawn-async@2.2.5
├─ cross-spawn@5.1.0
├─ cryptiles@3.1.2
├─ currently-unhandled@0.4.1
├─ dashdash@1.14.1
├─ decamelize@1.2.0
├─ decompress-zip@0.3.0
├─ deep-extend@0.4.2
├─ delayed-stream@1.0.0
├─ delegates@1.0.0
├─ detect-indent@4.0.0
├─ detect-libc@1.0.3
├─ ds-store@0.1.6
├─ ecc-jsbn@0.1.1
├─ electron-download@4.1.0
├─ electron-forge-template-angular2@1.0.6
├─ electron-forge-template-react-typescript@1.0.6
├─ electron-forge-template-react@1.0.4
├─ electron-forge-template-vue@1.0.3
├─ electron-forge@5.1.1
├─ electron-installer-debian@0.8.1
├─ electron-installer-dmg@0.2.1
├─ electron-installer-flatpak@0.8.0
├─ electron-installer-redhat@0.5.0
├─ electron-installer-snap@2.0.1
├─ electron-osx-sign@0.4.9
├─ electron-packager@11.1.0
├─ electron-rebuild@1.7.3
├─ electron-windows-store@0.12.0
├─ electron-winstaller@2.6.4
├─ electron-wix-msi@1.3.0
├─ end-of-stream@1.4.1
├─ env-paths@1.0.0
├─ error-ex@1.3.1
├─ es6-promise@4.2.4
├─ es6-promisify@5.0.0
├─ esprima@4.0.0
├─ events@1.1.1
├─ execa@0.7.0
├─ exit-hook@1.1.1
├─ expand-tilde@2.0.2
├─ extend@3.0.1
├─ external-editor@2.1.0
├─ extract-zip@1.6.6
├─ extsprintf@1.3.0
├─ fast-deep-equal@1.1.0
├─ fast-json-stable-stringify@2.0.0
├─ fd-slicer@1.0.1
├─ figures@2.0.0
├─ find-up@2.1.0
├─ findit2@2.2.3
├─ flatpak-bundler@0.1.3
├─ flatten-packages@0.1.4
├─ fmix@0.1.0
├─ forever-agent@0.6.1
├─ form-data@2.3.2
├─ fs-extra@4.0.3
├─ fs-temp@1.1.2
├─ fs-xattr@0.1.17
├─ fs.realpath@1.0.0
├─ fstream@1.0.11
├─ gar@1.0.3
├─ gauge@1.2.7
├─ generate-function@2.0.0
├─ generate-object-property@1.2.0
├─ get-folder-size@1.0.1
├─ get-installed-path@2.1.1
├─ get-package-info@1.0.0
├─ get-stdin@4.0.1
├─ get-stream@3.0.0
├─ getpass@0.1.7
├─ glob@7.1.2
├─ global-modules@1.0.0
├─ global-prefix@1.0.2
├─ globals@9.18.0
├─ har-schema@2.0.0
├─ har-validator@5.0.3
├─ has-ansi@2.0.0
├─ has-flag@3.0.0
├─ has-own-property-x@3.2.0
├─ hawk@6.0.2
├─ home-or-tmp@2.0.0
├─ hosted-git-info@2.5.0
├─ http-signature@1.2.0
├─ iconv-lite@0.4.19
├─ ieee754@1.1.8
├─ image-size@0.5.5
├─ indent-string@2.1.0
├─ infinity-x@1.0.2
├─ inherits@2.0.3
├─ ini@1.3.5
├─ inquirer@5.1.0
├─ invariant@2.2.3
├─ invert-kv@1.0.0
├─ is-array-buffer-x@1.7.0
├─ is-array-buffer@1.0.0
├─ is-arrayish@0.2.1
├─ is-builtin-module@1.0.0
├─ is-date-object@1.0.1
├─ is-falsey-x@1.0.3
├─ is-finite-x@3.0.4
├─ is-finite@1.0.2
├─ is-fullwidth-code-point@1.0.0
├─ is-function-x@3.3.0
├─ is-index-x@1.1.0
├─ is-my-ip-valid@1.0.0
├─ is-my-json-valid@2.17.2
├─ is-nil-x@1.4.2
├─ is-object-like-x@1.7.1
├─ is-promise@1.0.1
├─ is-property@1.0.2
├─ is-stream@1.1.0
├─ is-string@1.0.4
├─ is-typedarray@1.0.0
├─ is-utf8@0.2.1
├─ is-wsl@1.1.0
├─ isbinaryfile@3.0.2
├─ isexe@2.0.0
├─ isstream@0.1.2
├─ jmespath@0.15.0
├─ js-tokens@3.0.2
├─ js-yaml@3.11.0
├─ jsesc@1.3.0
├─ json-schema-traverse@0.3.1
├─ json-schema@0.2.3
├─ json-stringify-safe@5.0.1
├─ json5@0.5.1
├─ jsonpointer@4.0.1
├─ jsprim@1.4.1
├─ lazystream@0.1.0
├─ lcid@1.0.0
├─ load-json-file@1.1.0
├─ locate-path@2.0.0
├─ lodash.assign@4.2.0
├─ lodash.defaults@4.2.0
├─ lodash.difference@4.5.0
├─ lodash.filter@4.6.0
├─ lodash.get@4.4.2
├─ lodash.pad@4.5.1
├─ lodash.padend@4.6.1
├─ lodash.padstart@4.6.1
├─ lodash.pull@4.1.0
├─ lodash.template@4.4.0
├─ lodash.templatesettings@4.1.0
├─ lodash.uniq@4.5.0
├─ lodash@4.17.5
├─ log-symbols@2.2.0
├─ loose-envify@1.3.1
├─ loud-rejection@1.6.0
├─ lru-cache@4.1.1
├─ macos-alias@0.2.11
├─ map-obj@1.0.1
├─ math-clamp-x@1.2.0
├─ math-sign-x@3.0.0
├─ max-safe-integer@1.0.1
├─ mem@1.1.0
├─ meow@3.7.0
├─ mime-db@1.33.0
├─ mime-types@2.1.18
├─ mime@1.2.11
├─ minimatch@3.0.4
├─ minimist@1.2.0
├─ mkpath@0.1.0
├─ multiline@1.0.2
├─ murmur-32@0.1.0
├─ mute-stream@0.0.7
├─ mz@2.7.0
├─ nan@2.9.2
├─ natives@1.1.1
├─ nested-error-stacks@1.0.2
├─ node-abi@2.3.0
├─ node-fetch@2.1.1
├─ node-gyp@3.6.2
├─ nopt@3.0.6
├─ normalize-space-x@3.0.0
├─ npm-run-path@2.0.2
├─ npmlog@4.1.2
├─ nugget@2.0.1
├─ oauth-sign@0.8.2
├─ object-get-own-property-descriptor-x@3.2.0
├─ object-keys@0.4.0
├─ once@1.4.0
├─ onetime@2.0.1
├─ opn@5.2.0
├─ ora@1.4.0
├─ os-shim@0.1.3
├─ osenv@0.1.5
├─ p-finally@1.0.0
├─ p-limit@1.2.0
├─ p-locate@2.0.0
├─ p-try@1.0.0
├─ parse-author@2.0.0
├─ parse-color@1.0.0
├─ parse-int-x@2.0.0
├─ parse-passwd@1.0.0
├─ path-parse@1.0.5
├─ path-type@1.1.0
├─ performance-now@2.1.0
├─ pinkie@2.0.4
├─ plist@2.1.0
├─ pretty-bytes@1.0.4
├─ private@0.1.8
├─ process-nextick-args@2.0.0
├─ progress-stream@1.2.0
├─ promise@1.3.0
├─ property-is-enumerable-x@1.1.0
├─ pruner@0.0.7
├─ pseudomap@1.0.2
├─ punycode@1.3.2
├─ q@1.5.1
├─ qs@6.5.1
├─ random-path@0.1.1
├─ rc@1.2.5
├─ rcedit@1.0.0
├─ read-pkg@1.1.0
├─ readable-stream@1.0.34
├─ redent@1.0.0
├─ regenerator-runtime@0.11.1
├─ repeat-string@1.6.1
├─ replace-comments-x@2.0.0
├─ request@2.83.0
├─ require-object-coercible-x@1.4.3
├─ resolve-dir@1.0.1
├─ resolve-package@1.0.1
├─ resolve@1.5.0
├─ restore-cursor@2.0.0
├─ run-async@2.3.0
├─ rx-lite-aggregates@4.0.8
├─ rx-lite@4.0.8
├─ rx@4.1.0
├─ rxjs@5.5.6
├─ s3@4.4.0
├─ safe-buffer@5.1.1
├─ sanitize-filename@1.6.1
├─ sax@1.2.1
├─ semver@5.5.0
├─ set-blocking@2.0.0
├─ shebang-command@1.2.0
├─ shebang-regex@1.0.0
├─ sigmund@1.0.1
├─ single-line-log@1.1.2
├─ slash@1.0.0
├─ sntp@2.1.0
├─ source-map-support@0.4.18
├─ source-map@0.5.7
├─ spawn-rx@2.0.12
├─ spawn-sync@1.0.15
├─ spdx-correct@3.0.0
├─ spdx-exceptions@2.1.0
├─ speedometer@0.1.4
├─ sprintf-js@1.0.3
├─ sshpk@1.13.1
├─ stream-buffers@2.2.0
├─ streamsink@1.2.0
├─ stringstream@0.0.5
├─ strip-ansi@3.0.1
├─ strip-bom@2.0.0
├─ strip-eof@1.0.0
├─ strip-indent@1.0.1
├─ strip-json-comments@2.0.1
├─ sudo-prompt@8.1.0
├─ sumchecker@2.0.2
├─ supports-color@5.3.0
├─ symbol-observable@1.0.1
├─ tabtab@2.2.2
├─ tar-stream@0.4.7
├─ tar@2.2.1
├─ thenify-all@1.6.0
├─ thenify@3.3.0
├─ throttleit@0.0.2
├─ through@2.3.8
├─ through2@0.2.3
├─ tmp-promise@1.0.4
├─ tn1150@0.1.0
├─ to-boolean-x@1.0.3
├─ to-fast-properties@1.0.3
├─ to-integer-x@3.0.0
├─ to-string-symbols-supported-x@1.0.2
├─ to-string-tag-x@1.4.3
├─ touch@0.0.3
├─ tough-cookie@2.3.4
├─ traverse@0.3.9
├─ trim-newlines@1.0.0
├─ trim-right-x@3.0.0
├─ trim-right@1.0.1
├─ truncate-utf8-bytes@1.0.2
├─ tunnel-agent@0.6.0
├─ tweetnacl@0.14.5
├─ universalify@0.1.1
├─ unorm@1.4.1
├─ url-template@2.0.8
├─ url@0.10.3
├─ username@3.0.0
├─ utf8-byte-length@1.0.4
├─ util-deprecate@1.0.2
├─ uuid@3.2.1
├─ validate-npm-package-license@3.0.3
├─ verror@1.10.0
├─ which@1.3.0
├─ wide-align@1.1.2
├─ word-wrap@1.2.3
├─ wrap-ansi@2.1.0
├─ wrench@1.5.9
├─ xml2js@0.4.17
├─ xmlbuilder@4.2.1
├─ xmldom@0.1.27
├─ xtend@4.0.1
├─ yallist@2.1.2
├─ yargs-parser@5.0.0
├─ yargs@7.0.2
├─ yarn-or-npm@2.0.4
├─ yauzl@2.4.1
├─ zip-folder@1.0.0
└─ zip-stream@0.4.1
✨  Done in 11.56s.
bendemboski commented 6 years ago

Okay, let's try to replicate this with a clean project. Can you try creating a clean project, installing electron-forge, then in the project running

DEBUG=electron-forge:* ./node_modules/.bin/forge import
ksolo commented 6 years ago

In a clean project from running yarn init

$ DEBUG=electron-forge:* ./node_modules/.bin/forge import
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +770ms
  electron-forge:runtime-config setting key: verbose to value: false +0ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:import Attempting to import project in: /Users/ksolo/Projects/Chair-Flyers/sandbox +0ms
? WARNING: We will now attempt to import: "/Users/ksolo/Projects/Chair-Flyers/sandbox".  This will involve modifying some files, are you sure you
 want to continue? Yes
  electron-forge:lifecycle Process Started: Initializing Git Repository +0ms
  electron-forge:init:git executing "git init" in directory: /Users/ksolo/Projects/Chair-Flyers/sandbox +0ms
  electron-forge:lifecycle Process Succeeded: Initializing Git Repository +26ms
? Do you want us to change the "main" attribute of your package.json?  If you are currently using babel and pointing to a "build" directory say y
es. Yes
? Enter the relative path to your uncompiled main file index.js
  electron-forge:import reading current scripts object: {} +20s
? Do you want us to update the "start" script to instead call the electron-forge task "electron-forge start" Yes
? Do you want us to update the "package" script to instead call the electron-forge task "electron-forge package" Yes
? Do you want us to update the "make" script to instead call the electron-forge task "electron-forge make" Yes
  electron-forge:import forgified scripts object: { start: 'electron-forge start',
  package: 'electron-forge package',
  make: 'electron-forge make' } +19s
  electron-forge:lifecycle Process Started: Writing modified package.json file +29s
  electron-forge:lifecycle Process Succeeded: Writing modified package.json file +12ms
  electron-forge:lifecycle Process Started: Installing dependencies +1ms
  electron-forge:import deleting old dependencies forcefully +14ms
  electron-forge:import installing dependencies +3ms
  electron-forge:dependency-installer installing ["electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox dev=false,exact=false,withYarn=true +0ms
  electron-forge:dependency-installer executing ["add","electron-compile","electron-squirrel-startup"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox +0ms
  electron-forge:runtime-config fetching key verbose +0ms
  electron-forge:import installing devDependencies +3s
  electron-forge:dependency-installer installing ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox dev=true,exact=false,withYarn=true +3s
  electron-forge:dependency-installer executing ["add","babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge","--dev"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox +0ms
  electron-forge:runtime-config fetching key verbose +3s
  electron-forge:import installing exactDevDependencies +4s
  electron-forge:dependency-installer installing ["electron-prebuilt-compile@latest"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox dev=true,exact=true,withYarn=true +4s
  electron-forge:dependency-installer executing ["add","electron-prebuilt-compile@latest","--dev","--exact"] in: /Users/ksolo/Projects/Chair-Flyers/sandbox +0ms
  electron-forge:runtime-config fetching key verbose +4s
  electron-forge:lifecycle Process Succeeded: Installing dependencies +17s
  electron-forge:lifecycle Process Started: Writing modified package.json file +2ms
  electron-forge:lifecycle Process Succeeded: Writing modified package.json file +0ms
  electron-forge:lifecycle Process Started: Fixing .gitignore +1ms
  electron-forge:lifecycle Process Succeeded: Fixing .gitignore +0ms

We have ATTEMPTED to convert your app to be in a format that electron-forge understands.
Nothing much will have changed but we added the "electron-prebuilt-compile" dependency.  This is the dependency you must version bump to get newer versions of Electron.

We also tried to import any build tooling you already had but we can't get everything.  You might need to convert any CLI/gulp/grunt tasks yourself.

Also please note if you are using `preload` scripts you need to follow the steps outlined at https://github.com/electron-userland/electron-forge/wiki/Using-%27preload%27-scripts

Thanks for using "electron-forge"!!!

I'm also going to switch to Node 7.7 to see if that has an impact.

ksolo commented 6 years ago

I'm now trying ember-cli 2.18.2 to see if that will help.

ksolo commented 6 years ago

I can install electron-forge globally, but when I try to run

$ yarn add electron-forge --dev

I get

error An unexpected error occurred: "/Users/ksolo/Projects/Chair-Flyers/node-env-test/node8-test/node_modules/ember-electron/node_modules/electron-forge: Command failed.
Exit code: 1
Command: sh
Arguments: -c node tabtab-install.js
Directory: /Users/ksolo/Projects/Chair-Flyers/node-env-test/node8-test/node_modules/ember-electron/node_modules/electron-forge
Output:

Do you have a recommended node, ember-cli version to use? I can try that combination to see if that works.

ksolo commented 6 years ago

I really appreciate your help and patience with this

bendemboski commented 6 years ago

I'm really not sure why you're running into this issue. My first thought was to try a less recent Node version, but it sounds like you tried that? I seriously doubt the ember-cli version is affecting it, but I guess it's possible...I just tried installing ember-electron into a random Ember project that I have using ember-cli@2.18.2 on node 8.9.0 on MacOS and it worked fine...

@malept do you have any thoughts here? It looks likely that he's running in to a tabtab issue, although it happens using both the latest release version of ember-electron (still on electron-forge 4.1.x) and the head of master with your upgrade to 5.x.

malept commented 6 years ago

With the latest Forge, tabtab-installer.js should never exit with a non-zero status. Can you try DEBUG='tabtab:*' yarn add electron-forge --dev ? In theory that should give us some indication of what's happening on the tabtab side of things.

@MarshallOfSound I'm not sure installing tabtab autocompletions by default is worth this headache anymore. I'm inclined to replace it with electron-forge install-completions or something.

ksolo commented 6 years ago

I have a brand new ember project from ember new using node: 9.2.0 ember-cli: 3.0.0

$ DEBUG='tabtab:*' yarn add electron-forge --dev

That seems to run just fine:

✨  Done in 20.52s.

When I run

$ DEBUG='tabtab:*' ember install ember-electron

I get:

Command failed: yarn add --dev ember-electron --non-interactive
warning ember-electron > electron-forge > github@12.1.0: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
warning ember-electron > ember-inspector > ember-new-computed > ember-cli-babel > broccoli-babel-transpiler > babel-core > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
error An unexpected error occurred: "/Users/ksolo/Projects/Chair-Flyers/node-env-test/node9-test/node_modules/ember-electron/node_modules/electron-forge: Command failed.
Exit code: 1
Command: sh
Arguments: -c node tabtab-install.js
Directory: /Users/ksolo/Projects/Chair-Flyers/node-env-test/node9-test/node_modules/ember-electron/node_modules/electron-forge
Output:
nodejs 7.7 not installed".

yarn add v1.5.1
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Building fresh packages...
info If you think this is a bug, please open a bug report with the information provided in "/Users/ksolo/Projects/Chair-Flyers/node-env-test/node9-test/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
ksolo commented 6 years ago

I don't know why it seems to care about node 7.7. I'll try again, blowing away the lock files, and the node_modules directory.

ksolo commented 6 years ago

Same errors...

ksolo commented 6 years ago

Ok...I just installed in on my other computer, and it worked just fine. I'm going to close this issue and see how I can the node envs to match between machines.