Closed yashodhah closed 5 years ago
Hmm, there is no "electron-prebuilt-compile@5.0.1" published on NPM (see lament https://github.com/electron-userland/electron-prebuilt-compile/issues/77)
I just ran ember install ember-electron
on an empty/new ember project on Windows, and it works fine. Could you please share your package.json file? (Or at least the deps/devDeps entries for packages with electron
in their names)
ember-cli: 3.9.0
node: 12.1.0
os: win32 x64
I tried to reproduce this again using node 6.x and ember-cli 3.3 but so far have not been able to. I think it is happening because electron-forge is attempting to use the version number associated with the latest electron release (5.0.1) with the electron-prebuilt-compile package, which is behind. (See https://github.com/electron-userland/electron-forge/blob/5.x/src/api/import.js#L178-L180)
Could you enable debugging, try again, and post the log here?
DEBUG=electron-forge:*,ember-electron:* ember install ember-electron
When I do it on a fresh project I see a line like this:
electron-forge:dependency-installer installing ["electron-prebuilt-compile@latest"] in: C:\path\ee-test dev=true,exact=true,withYarn=true
but I suspect you'll see electron-prebuilt-compile@5.0.1
, which is why it's failing in your case.
@jacobq I have the same issue. It looks like changes from the master branch haven't been published to the npm (with a new tag).
@YD1722 You can make changes in package.json till the project maintainers don't publish it :
"ember-electron": "https://github.com/adopted-ember-addons/ember-electron.git",
It looks like changes from the master branch haven't been published to the npm (with a new tag).
Yes, and sorry for inconvenience. We're in the process of changing maintainers. However, I'm still puzzled as to why the problem is happening / what changes in master fix it. @PavloNaumenko could you share some debug output? Is it because of older electron-forge? If so, why can't I reproduce it? Lockfile issue?
@jacobq Hm, I can't reproduce it again. Maybe it was an npm cache?
This appears to be resolved, so I'm closing the issue.
OS : Windows 7 Node version : 6.9.2 Ember-cli :3.3