adopted-ember-addons / ember-electron

:zap: Build, test, compile and package desktop apps with Ember and Electron
https://ember-electron.js.org/
Other
805 stars 109 forks source link

Existing Ember project not launching with `ember electron` #51

Closed kdawgwilk closed 7 years ago

kdawgwilk commented 8 years ago

Here is my current versions

package.json electron dependency versions "electron-packager": "6.0.0", "electron-prebuilt": "0.37.5", "electron-rebuild": "1.1.3", "ember-electron": "1.3.2",

$ ember -v ember-cli: 2.4.3 node: 4.4.2 os: darwin x64

After running ember install ember-electron and configuring project trying to run ember electron gives me this:

screen shot 2016-04-07 at 11 47 08 pm

kdawgwilk commented 8 years ago

Also after running ember electron:package --platform darwin and trying to launch app I get this

screen shot 2016-04-07 at 11 56 55 pm

felixrieseberg commented 8 years ago

Thanks for reporting! I'ts a bit hard to see because of the whiteouts, but is there a comma in the app name? I'd assume that the trouble is that the app and the generator disagree over where the app is located. To fix:

felixrieseberg commented 8 years ago

Oh, and if you changed your app's name, you should probably run ember g ember-electron again.

kdawgwilk commented 8 years ago

Yeah sorry about the white out 😁 those are actually the letter y and the name is made up of just letters and - ? Any other ideas?

felixrieseberg commented 8 years ago

It's definitely the app name - or, if you're sure that the files are there on disk, you might have an error in that file that keeps it from being successfully exported.

kdawgwilk commented 8 years ago

Which file would have the error? electron.js?

SSS2557 commented 8 years ago

for me, with the same versions and OS, the electron app is just shown in the dock but no app window pops up :(

No errors too. I tried packaging it and opening the executable but still the same.

And to add to this information, the tests ember electron:test work just fine. Just not the app itself

Update: I forgot I was pointing to some express-server accommodating code. I probably need to re-try

kdawgwilk commented 8 years ago

I also was able to run the tests fine not sure why one would run and the other not

anulman commented 7 years ago

Closing due to age; please do reopen if this is still an issue 😄