search

adopted-ember-addons / ember-inputmask

Ember wrapper around Inputmask.js
https://adopted-ember-addons.github.io/ember-inputmask/
MIT License
68 stars 45 forks source link

Cents not being overwriiten #44

Open jrock2004 opened 7 years ago

jrock2004 commented 7 years ago

So I am using your plugin and when I type the numbers everything is getting replaced. Then I use the arrow keys to move before the cents symbol, hit the period and the cursor moves in front of first cent number. Then I try to hit a number and nothing happens.

Here is a link to an Ember Twiddle with an example https://ember-twiddle.com/d7e72b96e9e48b66b4c16988d15a947e?openFiles=routes.application.js%2C

Update 1: It appears that bug was introduced in version 0.4.0-beta.2 as when I set it to beta.1, it works

brandynbennett commented 6 years ago

@jrock2004 are you still seeing this? Your twiddle is set to 0.4.0-beta.5 and it seems to be working?

jrock2004 commented 6 years ago

@brandynbennett I just tried it again with that link and it still does not work.

brandynbennett commented 6 years ago

You're right. It still does that. I think it may have something to do with the underlying library. A notable change from 0.4.0-beta.1 to beta.2 was a bump in the inputmask library. I made a completely new component one-way-number-mask that has a different architecture and the same bug is happening. Looking into it more

brandynbennett commented 5 years ago

So when I looked at this just now each number you type adds a number, doesn't replace it. So if you have already fill up the maximum decimal places, moving the cursor with the arrows won't let you add any more decimals. However if you haven't typed all the decimals yet it will insert them.