adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 58 forks source link

keyResponder wrapped classic components missing component arguments #451

Closed bjornharrtell closed 11 months ago

bjornharrtell commented 3 years ago

We've been trying to upgrade to 6.x with the method described at http://adopted-ember-addons.github.io/ember-keyboard/deprecations but we get an unexpected problem in that component arguments becomes undefined. I've made a reproduction repository at https://github.com/bjornharrtell/ek-repro and the problem is specifically noted here:

https://github.com/bjornharrtell/ek-repro/blob/4f01de4646ec385490daa55643a03008b5859a69/app/components/withk.js#L7

While an otherwise identical component without keyResponder wrapping works as expected at https://github.com/bjornharrtell/ek-repro/blob/4f01de4646ec385490daa55643a03008b5859a69/app/components/withoutk.js#L6.

bjornharrtell commented 11 months ago

Obsolete, I think.

KeithKosh commented 8 months ago

@bjornharrtell I'm still encountering this issue. I'm running 8.2.1 of ember-keyboard and I have a classic component with two arguments passed in, but when I wrap it in keyResponder the two arguments always return undefined. (It doesn't matter if I use get(this, 'argumentName') or this.argumentName)

bjornharrtell commented 8 months ago

@KeithKosh mm yes I think perhaps we migrated away from classic components everywhere.