search

adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 57 forks source link

Fix ember-modifier v3.2 compatibility #620

Closed SergeAstapov closed 2 years ago

SergeAstapov commented 2 years ago

This is fix for the logic/condition introduced in #617

Condition about whether to use new or old version of on-key modifier class was flipped.

Additionally, this adds useWorkspaces to ember-try config so that proper version of ember-modifier is used across the monorepo.

This is needed so that ember-modifier-X ember-try scenarios resolve to the same version of ember-modifier both in the test-app and addon workspaces.

ember-classic scenario should not use useWorkspaces flag as only test-app need to get classic flags.

SergeAstapov commented 2 years ago

@lukemelia if this looks good, could you please release v8.1.1. sorry about the churn.

lukemelia commented 2 years ago

Thanks @SergeAstapov

lukemelia commented 2 years ago

Released as 8.1.1