search

adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 57 forks source link

Allow @ember/test-helpers v3 in peer dependencies #732

Closed francois2metz closed 1 year ago

francois2metz commented 1 year ago

@ember/test-helpers v3 has been released: https://github.com/emberjs/ember-test-helpers/releases/tag/v3.0.0

The triggerEvent function used in ember-keyboard is still here, so relaxing the dependencies to allow the v3 is okay.

francois2metz commented 1 year ago

Should fix #729

francois2metz commented 1 year ago

I believe we can drop build for ember 3.x now, And I can add @ember/string dependency to fix ember 5. What do you think?

SergeAstapov commented 1 year ago

@francois2metz we should do one thing at a time. v3 support should be dropped separately. I think we should be able to land this change as is

SergeAstapov commented 1 year ago

@francois2metz could you please revert changes related to v3 build from this PR? it's unrelated to the changes proposed here, we'll work on fixing CI separately

SergeAstapov commented 1 year ago

@lukemelia could you be able to publish v8.3.0 with this fix? I'll work on making CI green separately

lukemelia commented 1 year ago

Released as 8.2.1