search

adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 58 forks source link

Drop build on ember < 3.24 #734

Closed francois2metz closed 1 year ago

francois2metz commented 1 year ago

The compatibility table on the readme say that ember-keyboard v7 only support ember 4. It's probably time to drop the build on ember 3.x.

francois2metz commented 1 year ago

The build is now green \o/

SergeAstapov commented 1 year ago

This looks good to me. However, technically, this would be a breaking change. Wonder what @lukemelia thinks about this

lukemelia commented 1 year ago

If ember-keyboard 7 is not compatible with ember 3.x, we can cut 8.0 and be clear about this. I'm not in a rush to drop 3.x support if there is not a reason to do so. In particular, all things being equal, it would be helpful to retain support for 3.28 to make life easier for people upgrading to ember 4.

francois2metz commented 1 year ago

I'm a bit confused by the readme:

Ember 4 compatibility requires ember-keyboard 7.x or higher For Ember 3.8 to 3.28, you can use ember-keyboard 6.x (not compatible with Internet Explorer)

It seems that the ember 3 compabitility is not available on ember-keyboard 7. If not then we have our upgrade path for ember 3 users.

If we want to keep the ember 3.x compatibility, and I can try to use a compatible ember-modifier version.

francois2metz commented 1 year ago

I updated the branch to drop build on ember < 3.24. I also updated the dependencies to remove the polyfills that are now uneeded.

SergeAstapov commented 1 year ago

I'm a bit confused by the readme

looks like this is the root cause and we should update readme then, instead of a new major release as there is no actual reason to do so now (unless I'm missing something)