search

adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 58 forks source link

Remove test dependency ember-export-application-global that break most ember 5 tests #735

Closed francois2metz closed 1 year ago

francois2metz commented 1 year ago

I digged why ember 5 tests were failing. ember-export-application-global was installed but is now deprecated and doesn't seems to be necessary to run tests. There is one more test failing related to fastboot.

SergeAstapov commented 1 year ago

@francois2metz don't you need to re-roll yarn.lock?

francois2metz commented 1 year ago

It could be necessary but the doc app is still using it.