search

adopted-ember-addons / ember-keyboard

An Ember.js addon for the painless support of keyboard events
http://adopted-ember-addons.github.io/ember-keyboard/
Other
177 stars 57 forks source link

Addon's ember-source incompatible with Ember 5 #744

Closed Elawphant closed 1 year ago

Elawphant commented 1 year ago

Please fix the ember-source dependency

SergeAstapov commented 1 year ago

@Elawphant sorry could you be little bit more specific? ember-source is not listed in dependencies nor peerDependencies of this addon see https://github.com/adopted-ember-addons/ember-keyboard/blob/master/addon/package.json

Elawphant commented 1 year ago

hmm. very strange. I have removed my node_modules and trying to reinstall with all fresh dependencies. I got an error with this one too. But seems it should have not have risen.

NullVoxPopuli commented 1 year ago

looks like this is resolved?

SergeAstapov commented 1 year ago

Closing until we have a reproduction as issue reported here seems unrelated to ember-keyboard