search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
312 stars 131 forks source link

Merge post 2.0.0-beta.5 branches #775

Closed maxwondercorn closed 2 years ago

maxwondercorn commented 2 years ago

The PR merges branches origin/fw/update-dummy-app and 3.0.0-beta.0 by @Gorzas and @fran-worley. This is work after v2.0.0-beta.5 not merged into master.

I will continue updating the addon after the PR is merged.

edited: Merge only, no release...

RobbieTheWagner commented 2 years ago

@maxwondercorn could we also add a GitHub actions setup to run tests please? I would like to make sure tests are passing before merging.

maxwondercorn commented 2 years ago

Yes, I will set that up

@rwwagner90 Forgot I didn't have permissions on this repo so I can't setup actions atm. IIRC, I need to ask @Melanie#1618 on Discord. Will ping when they're setup -thanks

RobbieTheWagner commented 2 years ago

@maxwondercorn looks like we have a lot of lint failures. Can you please disable those rules or address the issues?

maxwondercorn commented 2 years ago

The rules were prematurely removed in one of the merged branches. Will fix or add them back.

Also working on Ember 3.20 failing tests

maxwondercorn commented 2 years ago

@rwwagner90

Tests are passing in CI. 🎉 Still a lot of work to do but this is a good starting point to continue from

I need to figure out testing differences between local and GitHub actions. Using ember-try locally the embroider tests pass but not in CI. Locally 3.20 source tests fail but pass in CI 🤷

RobbieTheWagner commented 2 years ago

Merged and marked as breaking just in case. Thanks for doing this!

maxwondercorn commented 2 years ago

Thanks for merge. I will keep working on this. I have repo access now but will still put PR's for review and merge as needed.