search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
311 stars 131 forks source link

Remove ember-responsive install from blueprint #810

Open maxwondercorn opened 2 years ago

RobbieTheWagner commented 2 years ago

@maxwondercorn are we sure we don't need this? I think the idea behind installing it is it will create the breakpoints.js file in the consuming app and set all that up.

maxwondercorn commented 2 years ago

@rwwagner90 I did forget about the breakpoints file. I was only looking at ember-responsive moving from devDependencies to addon dependencies. Does it really make sense to have it in both?

RobbieTheWagner commented 2 years ago

@maxwondercorn I think it should be in dependencies, since we're requiring it. Perhaps we could use afterInstall to run ember g ember-responsive or something like that?